-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: CoreManager
クラスの新設
#1227
Merged
Merged
整理: CoreManager
クラスの新設
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
すみません、コンフリクトの解消をお願いできると・・・! 🙇
@Hiroshiba |
Merged
This was referenced May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
CoreManager
クラスの新設によるリファクタリング現在の VOICEVOX ENGINE はコア集合に対する操作が複数存在している。
それぞれの操作をそれぞれの箇所で実装しているため実装が重複しており、またテストも不十分である。
コア集合に相当するクラスを新設し各種操作をメソッドとして集約すれば、無駄ない実装を確実にテストできる。
このような背景から、
CoreManager
クラスの新設によるリファクタリングを提案します。関連 Issue
無し
Review 向け補足情報
CoreManager
クラスの新設が主である。置き換えを意図したコア集合に対する操作は以下の通り:
get_core()
list(cores.keys())
core_version in cores
cores[core_version] = CoreAdapter(core)
また、
HTTPException
はTTSEngineManager
と同時に後継 PR にて修正予定(fixme 追加済み)。また、
test_core_initializer.py
の変更部は完全新規であり、本 PR の目的である「それぞれの操作をそれぞれの箇所で実装して ... テストも不十分」を反映して、テスト無しだった全ての操作にテストを新規実装している。