Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 対応デバイスモックの属性不足を修正
コアの対応デバイス一覧である
SupportedDevicesInfo
は 3 属性全てが required である。voicevox_engine/voicevox_engine/model.py
Lines 329 to 336 in 477cdb6
このインスタンスはコア由来の
supported_devices
文字列をパースして生成されている。ゆえにsupported_devices
文字列は 3 属性の json 文字列となっていなければならない。しかし現状のモックは属性が欠けているケースがあり、不正なモックとなっている。
このような背景から、対応デバイスモックの属性不足を修正することを提案します。
関連 Issue
無し