Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

追加: エンジン情報取得 API にドキュメントを追加 #1223

Merged
merged 1 commit into from
May 14, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 11, 2024

内容

概要: エンジン情報取得 API にドキュメントを追加

engine_info ルーターで定義されるエンジン情報取得 APIs には docstring が定義されていない。ゆえに API docs 生成でも API 詳細が生成されていない。

image

よって、docstring 追加によるエンジン情報取得 API へのドキュメント追加を提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 11, 2024 04:38
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 11, 2024 04:38
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit 67dbf5f into VOICEVOX:master May 14, 2024
3 checks passed
@tarepan tarepan deleted the add/info_docs branch May 14, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants