Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: License 登録を一箇所に集約 #1210

Merged
merged 1 commit into from
May 3, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 2, 2024

内容

License 登録を一箇所に集約してリファクタリング

関連 Issue

resolve #1182 (final step 🎉)

@tarepan tarepan requested a review from a team as a code owner May 2, 2024 08:40
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 2, 2024 08:40
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

行移動なことを確認しました!

これでgenerate_license.py周りは完了でしょうか?
(見た感じTODOコメントがちょっと残ってるかも)

@Hiroshiba Hiroshiba merged commit 2e3c60d into VOICEVOX:master May 3, 2024
3 checks passed
@tarepan tarepan deleted the refactor/license_once branch May 3, 2024 07:23
@tarepan
Copy link
Contributor Author

tarepan commented May 3, 2024

見た感じTODOコメントがちょっと残ってる

名称変更の TODO が残っているので、後継 PR (#1214) として取り組みます👍️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: ライセンス生成の重複処理を削除
2 participants