Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: generate_router() 名とインポート方式を個別化 #1207

Merged
merged 1 commit into from
May 3, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 2, 2024

内容

router 名にモジュール名を追加し個別モジュールから直接インポートしてリファクタリング

関連 Issue

resolve #1181

@tarepan tarepan requested a review from a team as a code owner May 2, 2024 05:20
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 2, 2024 05:20
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

綺麗ですね!!

@Hiroshiba Hiroshiba merged commit a90361b into VOICEVOX:master May 3, 2024
3 checks passed
@tarepan tarepan deleted the refactor/router_name branch May 3, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: generate_router() 名とインポート方式を個別化
2 participants