Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
問題としていたものを解決する手段ではありませんでしたが、テスト時間が短くなるはずのリファクタリングでもあるので、draftを開けてレビュー可能としたいと思います！ |
Hiroshiba
commented
May 1, 2024
Comment on lines
-30
to
+29
| # バージョン取得テスト | ||
| req = Request(base_url + "version") | ||
| with urlopen(req) as res: | ||
| assert len(res.read()) > 0 | ||
| # 起動待機 |
There was a problem hiding this comment.
バージョンが取得できることはまあここでのテストの意図ではないかなと思ったので、起動待機に意図を変更しました。
tarepan
approved these changes
May 1, 2024
|
レビューありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ビルド後のテストで、エンジンの待機が一律で６０秒だったのを、１５秒〜１５０秒にしました。
これで早めにエンジン起動が終わった場合は早めにテストが終わると思います。
サーバーの待機を６０秒から１５秒×１０回にします。
その他
macosで動かない問題の解決になると思っていたPRですが、そもそも環境が良くなくて落ちてたっぽく、起動時間は関係ありませんでした。
↑の解決PRはこちらです。