-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: サーバ初期設定と立ち上げの見通し改善 #1198
整理: サーバ初期設定と立ち上げの見通し改善 #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
まだ見切っていないのですが、ちょっとコメントをいくつかしました 🙇
結構コーディングの哲学的なところも含んでる気がするので、価値観が合わなかったら遠慮なくご指摘ください 🙇
@Hiroshiba |
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
@Hiroshiba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
内容
run.py
における「サーバ引数の設定」と「引数を用いたサーバー生成」を明確化してリファクタリングした。関連 Issue
無し