Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

追加: ランタイムファイルの種別を記述 #1180

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Apr 10, 2024

内容

README.md にランタイムファイルの種別を記述した

語彙利用:

関連 Issue

part of #1173

@tarepan tarepan requested a review from a team as a code owner April 10, 2024 04:27
@tarepan tarepan requested review from Hiroshiba and removed request for a team April 10, 2024 04:27
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 517 197 coverage-62%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 97 75 coverage-23%
voicevox_engine/core/init.py 0 0 coverage-100%
voicevox_engine/core/core_adapter.py 81 6 coverage-93%
voicevox_engine/core/core_initializer.py 60 30 coverage-50%
voicevox_engine/core/core_wrapper.py 228 160 coverage-30%
voicevox_engine/dev/init.py 0 0 coverage-100%
voicevox_engine/dev/core/init.py 0 0 coverage-100%
voicevox_engine/dev/core/mock.py 65 2 coverage-97%
voicevox_engine/dev/tts_engine/init.py 0 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 36 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 11 0 coverage-100%
voicevox_engine/engine_manifest/init.py 0 0 coverage-100%
voicevox_engine/library_manager.py 92 4 coverage-96%
voicevox_engine/metas/Metas.py 36 0 coverage-100%
voicevox_engine/metas/MetasStore.py 28 1 coverage-96%
voicevox_engine/metas/init.py 0 0 coverage-100%
voicevox_engine/model.py 180 3 coverage-98%
voicevox_engine/morphing.py 72 4 coverage-94%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 82 2 coverage-98%
voicevox_engine/preset/init.py 0 0 coverage-100%
voicevox_engine/setting/Setting.py 9 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 20 0 coverage-100%
voicevox_engine/setting/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_mapping.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/phoneme.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 268 9 coverage-97%
voicevox_engine/user_dict/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/user_dict/user_dict.py 146 12 coverage-92%
voicevox_engine/utility/init.py 0 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_utility.py 6 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2452 526 coverage-79%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ちなみに共有ライブラリか動的ライブラリどっちが良いかDiscordで議論していたのですが、たぶんどっちでもよく、たぶん多数決を取ると動的ライブラリになりそうな直感でした。

で、少なくともエンジンから見るとコアは共有ではなく動的なので、仮にcore.dllもなんとかライブラリと呼ばないといけない場合、「動的」のが正しくなりそうです。
Discordからのコピー

お そういえばエンジンはonnxruntime.dllを"共有"して複数のコアdllから利用してる・・・?
逆にコアdllは"動的"に複数読み込んで利用している・・・?
ということはエンジンにとってonnxruntime.dllは共有ライブラリで、コア.dllは動的ライブラリでは!
少なくともコア.dllを共有ライブラリと呼ぶと、複数読み込んでることと衝突してしまうかも
だからコア・エンジンで用語を統一するなら「動的ライブラリ」。
onnxruntime.dll等の共有感を残すなら、それらだけ「共有ライブラリ」。
とかでも良いのかもしれない。

(あと、今思ったらonnxruntimeとかをそう呼びたいので「ランタイムライブラリ」などと呼ぶのが一番わかりやすいかもとか思いました 😇 )

@Hiroshiba Hiroshiba merged commit ab927d4 into VOICEVOX:master Apr 30, 2024
3 checks passed
@tarepan tarepan deleted the add/clear_runtime_docs branch April 30, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants