Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: e2e single API テスト vol 8 #1166
整理: e2e single API テスト vol 8 #1166
Changes from 3 commits
7eaafec
06007be
7474669
554ec67
6602f9c
cfc9b23
5ae4871
3ba6bfb
acb6660
06f2509
3246d54
0c6dfef
5c541ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかnumpy辺りはtobufferみたいなのでバイナリにできるので、それ渡すhash_long_bytesみたいなのをいつか作っても良いかもですね。
ちょっと正確でちょっと早そうでちょっと意図が明確、くらいの気持ちですが
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
round_floats()
の入力がndarray
でなくfloat
であり、現時点でこの実装をするのは難しそうです。round_floats()
変更は本 PR で触っていない複数のファイル編集を要するため、別のリファクタリング PR で将来的に対処するのが review 上好ましいと考えます。「本 PR では対処無し」の方針で問題ないでしょうか?