-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style_id引数やAPIをspeakerに戻す #1016
The head ref may contain hidden characters: "style_id\u5F15\u6570\u3084API\u3092speaker\u306B\u623B\u3059"
style_id引数やAPIをspeakerに戻す #1016
Conversation
@@ -255,7 +255,7 @@ echo -n "モーフィングを利用することで、2種類の声を混ぜ | |||
|
|||
curl -s \ | |||
-X POST \ | |||
"127.0.0.1:50021/audio_query?style_id=0"\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
モーフィング用のスタイルIDが、製品版で実行不可能なペアだったのでついでに書き換えてみました。
つむぎちゃんとはうちゃんです。
@@ -290,16 +271,12 @@ def get_core(core_version: Optional[str]) -> CoreAdapter: | |||
) | |||
def audio_query( | |||
text: str, | |||
style_id: StyleId | None = None, | |||
speaker: StyleId | None = Query(default=None, deprecated=True), # noqa: B008 | |||
style_id: StyleId = Query(alias="speaker"), # noqa: B008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この書き方をすると、API引数ではspeaker
として受けつけて、Python内ではstyle_id
として実装できます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テストの関数の名称が変わったからスナップショットのパスが変わっただけ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openapi.jsonのスナップショットです。一応openapi-generatorが動くことも確認しています。
こちら必要になるのでマージします! |
内容
こちらの課題を一旦解決します。
READMEのコマンドも一通り動かしました。
関連 Issue
その他