Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style_id引数やAPIをspeakerに戻す #1016

Merged

Conversation

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 18, 2024 20:16
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 18, 2024 20:16
Copy link

github-actions bot commented Jan 18, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 484 304 coverage-37%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 94 72 coverage-23%
voicevox_engine/core_adapter.py 60 17 coverage-72%
voicevox_engine/core_initializer.py 59 30 coverage-49%
voicevox_engine/core_wrapper.py 225 159 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 36 8 coverage-78%
voicevox_engine/dev/tts_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 92 5 coverage-95%
voicevox_engine/metas/Metas.py 34 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 164 9 coverage-95%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 17 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_list.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 177 11 coverage-94%
voicevox_engine/user_dict.py 145 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2261 705 coverage-69%

@@ -255,7 +255,7 @@ echo -n "モーフィングを利用することで、2種類の声を混ぜ

curl -s \
-X POST \
"127.0.0.1:50021/audio_query?style_id=0"\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

モーフィング用のスタイルIDが、製品版で実行不可能なペアだったのでついでに書き換えてみました。
つむぎちゃんとはうちゃんです。

@@ -290,16 +271,12 @@ def get_core(core_version: Optional[str]) -> CoreAdapter:
)
def audio_query(
text: str,
style_id: StyleId | None = None,
speaker: StyleId | None = Query(default=None, deprecated=True), # noqa: B008
style_id: StyleId = Query(alias="speaker"), # noqa: B008
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この書き方をすると、API引数ではspeakerとして受けつけて、Python内ではstyle_idとして実装できます。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストの関数の名称が変わったからスナップショットのパスが変わっただけ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openapi.jsonのスナップショットです。一応openapi-generatorが動くことも確認しています。

@Hiroshiba
Copy link
Member Author

こちら必要になるのでマージします!

@Hiroshiba Hiroshiba merged commit 9e1b0f0 into VOICEVOX:master Jan 20, 2024
3 checks passed
@Hiroshiba Hiroshiba deleted the style_id引数やAPIをspeakerに戻す branch January 20, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant