-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[project-s] ハミング用APIを追加 #1008
Merged
Merged
[project-s] ハミング用APIを追加 #1008
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f1a4c7f
update metas (add style type)
y-chan babc923
update engine manifest (add frame rate)
y-chan 1da6ec8
add sing api to core wrapper
y-chan 844ef22
add sing api to core adapter
y-chan 9132a84
add models for sing api
y-chan 062e91b
add sing process to tts engine
y-chan 09af2c2
add sing api
y-chan 202bfbe
fix miss
y-chan 9002cc6
add fixme comment
y-chan afd5c12
remove sing type
y-chan 475c88e
fix typo
y-chan 12b8fc6
remove optional
y-chan d1cea98
translate error detail
y-chan 352cf6b
get -> create
y-chan b82a9d6
fix docs
y-chan ff0fad3
Revert "remove optional"
y-chan efdb7eb
fix pytest
y-chan 5f5b820
add comment
y-chan 92dcd91
add fixme comment
y-chan 4d3d3df
improve models
y-chan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
判断メモです。
ここをsingにすべきかsongにすべきかですごく迷うのですが、これは「歌うためのクエリ」であり、「歌のクエリ」ではないので、singが合っているのかなと思いました。
もし仮に名詞にするならsongではなくsong_snyhtesisとかかなと。長いのでsingで良さそう。