メモリリークしていた部分を修正した #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newしてそのまま開放されていないものがあったのでnew使うのをやめた
|
できるだけ元の実装と同じになるようにしてますが、一部コンパイルが通らなくなったのでnewしているところ以外も手を加えてます |
Hiroshiba
reviewed
Mar 11, 2022
There was a problem hiding this comment.
おお！！良いですね！！！
誰か動作確認できたらマージしちゃいたいと思います。
そういえば @qwerty2501 さん、Cのテスト書いた経験あったりされますか…？
大掛かりな修正の前にテストがあるとすごく便利そうだなと思った一方、経験がないとデファクトがわからず…。
（google testが良いっぽい気がしてはいます）
|
自作のC#アプリで動作確認できました。 |
|
おー！！ありがとうございます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
newしてそのまま開放されていないものがあったのでnew使うのをやめた
その他
要動作確認