Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump url to v2.5.4 #890

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore(deps): bump url to v2.5.4 #890

merged 1 commit into from
Dec 10, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 9, 2024 •
edited
Loading

内容

RUSTSEC-2024-0421が登録されたことによりcargo-denyが反応するようになったため。

See-also: Unicode License v3

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba December 9, 2024 19:15
Hiroshiba
Hiroshiba approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

（Unicode License v3、普通に他のライセンスと同じな気がしますが、なんでわざわざ独自のが別あるんだろう）

@qryxip
Copy link
Member Author

qryxip commented Dec 10, 2024 •
edited
Loading

このPRで追加されたzerofrom (Unicode-3.0)のreadmeによると、

The project is released under LICENSE, the free and open-source Unicode License, which is based on the well-known MIT license, with the primary difference being that the Unicode License expressly covers data and data files, as well as code. For further information please see The Unicode Consortium Intellectual Property, Licensing, and Technical Contribution Policies.

だそうです。

@qryxip qryxip merged commit 0edf940 into VOICEVOX:main Dec 10, 2024
34 checks passed
@Hiroshiba
Copy link
Member

なるほどデータファイル！！

@qryxip qryxip mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba