feat: fix up #875 about MARGIN_WIDTH and FEATURE_SIZE
#880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#875 で追加された以下のコードに対し、
voicevox_core/crates/voicevox_core_c_api/src/compatible_engine.rs
Lines 384 to 385 in d8e021e
以下の変更を加える。
MARGIN_WIDTH: Rust APIのものを持って来るようにすることで重複を避けるFEATURE_SIZE: 出力サイズのチェック時に失敗したとき、ncolsがFEATURE_SIZEと異なるならパニックメッセージを別のものにする関連 Issue
Refs: #875
その他
Cc: @Yosshi999