change!(java): blockingパッケージを作ってクラス移動
#861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Oct 23, 2024
There was a problem hiding this comment.
本PRのなかで唯一これだけ役割と挙動の変更を行っている。
他は全部コード移動。
Hiroshiba
approved these changes
Oct 24, 2024
|
一週間以上経ったのでマージしちゃおうと思います！ |
qryxip
deleted the
change-java-create-blocking-package-and-move-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Java APIに
voicevoxcore.blockingパッケージを作り、Synthesizerなどをそこに入れる。それに伴い、同期版APIでも非同期版APIでも共通するであろう次のクラスは分離してblockingの外のパッケージに置く。voicevoxcore.{Synthesizer. => }AccelerationModevoicevoxcore.{VoiceModelFile. => }SpeakerMetavoicevoxcore.{VoiceModelFile. => }StyleMetavoicevoxcore.{VoiceModelFile. => }StyleTypevoicevoxcore.{UserDict.Word => UserDictWord}関連 Issue
Refs: #769 (comment)
その他