refactor: Rust APIにおけるgetterをパブリックAPIとして整える #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Jul 10, 2024
3 tasks
Hiroshiba
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
題の通りです。
SupportedDevices,SpeakerMeta系: VOICEVOX CORE側から一方的に返すものなのでopen structでよいAudioQuery系: 「不正なAudioQuery」という概念は一応今は定義されていないため、open structでよいUserDictWord: 上記とは異なり、「不正なUserDictWord」という概念が存在するためgetterを定義surfaceとpronunciationとpriorityだけだったらUserDictWord{Surface,…}を作ればよいのだが、「accent_typeは単語のモーラ数を超過してはならない」という制約もある関連 Issue
ref #388
その他