change: VVMにUUIDを割り振り、それをVoiceModelIdとする
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
May 23, 2024
Hiroshiba
reviewed
May 23, 2024
Comment on lines
-288
to
+290
| pub extern "C" fn voicevox_voice_model_id(model: &VoicevoxVoiceModel) -> VoicevoxVoiceModelId { | ||
| pub extern "C" fn voicevox_voice_model_id(model: &VoicevoxVoiceModel) -> VoicevoxVoiceModelId<'_> { | ||
| init_logger_once(); | ||
| model.id().as_ptr() | ||
| model.model.id_ref().raw_voice_model_id().as_bytes() |
There was a problem hiding this comment.
あ、そうか、VoiceModelIdは露出するんですね。
（配布する製品版VVMのドキュメントにもVoiceModelId書いた方が良いな～と思った次第です）
Hiroshiba
approved these changes
May 23, 2024
以下のためuuidもアップデートする。 <uuid-rs/uuid#741>
|
@takejohn 共有です。
|
Hiroshiba
pushed a commit
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#581 (comment)の3.です。manifest.jsonにUUIDとして
idを持たせ、それをVoiceModelIdとして扱います。パブリックAPIにおける"model_id"のような名前は全部"model_uuid"に置き換えるべきかもしれませんが、
idのままでも不自然ではないということもあって迷ったのでやらないでおきました。関連 Issue
ref #581
その他
sample.vvmの
idは、RFC 9562を記念して(?)UUID V7を使ってみました。