Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: style_id_to_model_inner_id → style_id_to_inner_voice_id #795

Merged
merged 1 commit into from
May 23, 2024
Merged

change: style_id_to_model_inner_id → style_id_to_inner_voice_id #795

merged 1 commit into from
May 23, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 23, 2024

内容

#581 (comment)の2.です。style_id_to_model_inner_idをstyle_id_to_inner_voice_idにします。

関連 Issue

ref #581

その他

@qryxip qryxip requested a review from Hiroshiba May 23, 2024 15:24
Hiroshiba
Hiroshiba approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

あ。これでサンプルのVVMファイルが読めなくなりますね。
色々実装されたら作り直さねば。

@Hiroshiba Hiroshiba merged commit 9c3a94e into VOICEVOX:main May 23, 2024
31 checks passed
@qryxip qryxip mentioned this pull request May 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba