chore: actionlint v1.7.0に適応する #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
May 9, 2024
There was a problem hiding this comment.
dtolnay/rust-toolchainのものを踏まえて設定。
There was a problem hiding this comment.
upload-artifact/download-artifactについては下記参照。
- GitHub Actions – Artifacts v4 is now Generally Available - The GitHub Blog
- actions/upload-artifact/docs/MIGRATION.md
まとめると:
- upload-artifactとdownload-artifactはセット。v3以前のartifactはdownload-artifact v4と互換性が無い（逆もそう?）
- v3以前では同一artifactにバラバラのタイミングで別々のファイルを投げ込むことができたが、v4ではartifactは"immutable"となる。そういうことがやりたければactions/upload-artifact/mergeというのが用意されている。
There was a problem hiding this comment.
@qryxip
情報共有ありがとうございます！
ENGINE も Node.js 周りで各 Actions のアップグレードが必要そうなのでマイグレーション情報助かりました。
|
今上げてもいいとは思うのですが、PRタイトルから若干離れそうなのと、後でRenovateをactionに対して導入しようかなとちょっと考えているのでそのときでいいかなと。 |
その規模だと、基本的にはプルリク別々のがありがたかったりします！ 変更前後で挙動に差がないリファクタリングとかはついでに加えるのOKだと思います。 |
qryxip
added a commit
to qryxip/oaclt
that referenced
this pull request
Oct 2, 2024
VOICEVOX/voicevox_core#792 と同じように、怒られている部分に対応する。
qryxip
added a commit
to qryxip/oaclt
that referenced
this pull request
Oct 2, 2024
VOICEVOX/voicevox_core#792 と同じように、怒られている部分に対応する。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下の二つを行い、2024-05-09にリリースされたactionlint v1.7.0に対応します。
nameとdescriptionを埋める関連 Issue
その他