Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Rust以外の1つの言語でのコア機能追加実装はしない方針であることを明記 #632

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Oct 9, 2023

内容

の解決PRです。
理由は「一貫性を保つため」としています。

関連 Issue

fix #631

その他

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ryo Yamashita <[email protected]>
@Hiroshiba Hiroshiba requested a review from qryxip October 9, 2023 15:22
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 43b63d7 into VOICEVOX:main Oct 9, 2023
27 checks passed
@Hiroshiba
Copy link
Member Author

マージします!

@Hiroshiba Hiroshiba deleted the Rust以外の1つの言語でのコア機能追加実装はしない方針であることを明記 branch October 9, 2023 15:29
qryxip added a commit that referenced this pull request Nov 11, 2024
#632 に続く形で、独立した"APIデザイン ガイドライン"を追加する。内容とし
てはとりあえず"Rust 以外の言語の API"とし、newtype以外にも言及したものを
用意する。

Refs: #631, #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1つの言語にだけ機能実装するようなプルリクエストをどうするか
2 participants