Fix up #486 #487
Merged
Fix up #486 #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#486 においてcommit suggestionを押した後CIを待たずにマージした結果、ビルドが通らない状態になっているため直します。
関連 Issue
#[serde(default)]を入れる #486その他
Rustの
Option<T>はPythonやTSのような合併型 (union type)ではなく、直和型 (sum type) (a.k.a. ADT, tagged union)と言えるものです。TはOption<T>のサブタイプではないため、値を書くときはNoneではない場合もSome(…)と書く必要があります。