Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download.md #272

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Fix download.md #272

merged 3 commits into from
Sep 12, 2022

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 11, 2022

内容

--accelerator cudaとなるべき箇所が--type cudaのままなのを修正します。

関連 Issue

その他

@qryxip qryxip temporarily deployed to false September 11, 2022 16:51 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:51 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:52 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:52 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:52 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:52 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:53 Inactive
@qryxip qryxip temporarily deployed to false September 11, 2022 16:53 Inactive
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

qwerty2501
qwerty2501 previously approved these changes Sep 11, 2022
Copy link
Contributor

@qwerty2501 qwerty2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qwerty2501 qwerty2501 dismissed their stale review September 11, 2022 23:18

directmlも必要そうだったので

Copy link
Contributor

@qwerty2501 qwerty2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません。directmlも同様の修正が必要そうなのでお願いしても良いでしょうか?

./download.ps1 -type directml

@qryxip
Copy link
Member Author

qryxip commented Sep 12, 2022

修正しました。

Copy link
Contributor

@qwerty2501 qwerty2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qwerty2501 qwerty2501 merged commit 4e07e7c into VOICEVOX:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants