Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up #3 #4

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Apr 16, 2024

内容

#3 に対するPRです。

#3 (comment)

関連 Issue

スクリーンショット・動画など

その他

@qryxip qryxip changed the title Windowsではuse-github-cacheuse-local-cachefalseにする Fix up #3 Apr 16, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

コメントだけお願いできれば!
あとはマージしちゃって頂けると!

@qryxip
Copy link
Member Author

qryxip commented Apr 21, 2024

あとはマージしちゃって頂けると!

マージボタン押せるの、多分ヒホさんとYちゃんさんの二人だけになってると思います。
そちらで押していただけると。(あるいはVOICEVOX/core-maintainerから私にwrite以上の権限を付与するか)

@Hiroshiba
Copy link
Member

おっとなるほどです、この辺り整備しないとですね。。
とりあえずマージします!

@Hiroshiba Hiroshiba merged commit 963a74b into VOICEVOX:for-onnxruntime-1.17.0 Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants