[project-s] Escキーでノートの選択を全て解除できるようにする #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 28, 2024
| } from "@/infrastructures/AudioRenderer"; | ||
| } from "@/sing/audioRendering"; |
There was a problem hiding this comment.
なるほどな移動だと思いました！
層構造を考えるとinfrastructuresのが合ってるとは思います。
が、その場合storeが直接これを参照するのはおかしいんですよね。
でもinfrastructuresに置くならInterfaceを用意したくなる。けどそうすると実装コストが高すぎる･･･。
難しいですね･･･。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Escキーでノートの選択を全て解除できるようにします。
また、以下も行います。
AudioRenderer.tsをsingディレクトリに移動し、名前をaudioRendering.tsに変更関連 Issue
VOICEVOX/voicevox_project#15
その他