Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] Openapiを0.16.0-dev用に更新 #1769

Merged

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 28, 2024

内容

エンジン側で継続的にビルドしている0.16.0-devのものにopenapiをあわせます。

最終的にどうなるか未定ですが、style_idではなくspeakerになっています。
あとtype: singが増えています。
sing対応しているスタイルは999から6000に変わりました。

関連 Issue

その他

どれがハミングなのかわかりづらいかもですが、これでとりあえず誰でも動かせる形になったはず!!

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 28, 2024 01:12
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 28, 2024 01:12
@Hiroshiba Hiroshiba changed the base branch from main to project-s January 28, 2024 01:12
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!
(0.16.0-devのエンジンで試してみたのですが、めたんちゃんのノーマルとあまあまが逆になってる?気がします…!)

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!!マージします!

metasが変かもな点確認します、ありです!!!

@Hiroshiba Hiroshiba merged commit 55a497c into VOICEVOX:project-s Jan 28, 2024
8 checks passed
@Hiroshiba Hiroshiba deleted the openapiを0.16.0-dev用に更新 branch January 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants