[project-s] キャラクターメニューの調整 #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
commented
Jan 26, 2024
Comment on lines
+104
to
+117
| const description: string[] = []; | ||
| if (style.styleType === "talk") { | ||
| description.push("トーク"); | ||
| } else if (style.styleType === "humming") { | ||
| description.push("ハミング"); | ||
| } else if (style.styleType === "sing_teacher") { | ||
| description.push("歌"); | ||
| } else { | ||
| throw new Error("Unknown style type."); | ||
| } | ||
| if (style.styleName != undefined) { | ||
| description.push(style.styleName); | ||
| } | ||
| return description.join("・"); |
There was a problem hiding this comment.
ひとまずhummingは「ハミング」、sing_teacherは「歌」と表示するようにしています。
また、styleTypeとstyleNameは「・」で区切っています。
Hiroshiba
approved these changes
Jan 26, 2024
Hiroshiba
reviewed
Jan 26, 2024
| return ( | ||
| style.styleId === store.state.singer?.styleId && | ||
| style.engineId === store.state.singer?.engineId | ||
| ); | ||
| })?.styleName; | ||
| }); | ||
| return style != undefined ? getStyleDescription(style) : ""; |
There was a problem hiding this comment.
これもエラーの握り潰しになっちゃってる雰囲気があるんですが、エンジンが準備できてないときは必ずundefinedになるので、結構どうしようもないんですよね･･･。
これは結局、このviewが本来準備できていないはずの状態でインスタンス化しようとさせられるのが課題だろうな～と思っています。
（ボイボエディタ全体的に、Vueの起動シーケンスの整理が追いついてない）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
humming・sing_teacherタイプのスタイルのみ表示するようにする関連 Issue
VOICEVOX/voicevox_project#15
その他