Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] キャラクターメニューおよび全身ポートレート表示 #1750

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

romot-co
Copy link
Contributor

@romot-co romot-co commented Jan 24, 2024

内容

以下の変更を行います

  • キャラクターを全身表示させる
  • キャラクターメニューをドロップダウン選択式にする

関連 Issue

ref #1696
close #1696

スクリーンショット・動画など

スクリーンショット 2024-01-24 19 40 15
スクリーンショット 2024-01-24 19 48 26

その他

@romot-co romot-co requested a review from a team as a code owner January 24, 2024 10:45
@romot-co romot-co requested review from Hiroshiba and removed request for a team January 24, 2024 10:45
@romot-co romot-co changed the title #1696 キャラクターメニューおよび全身ポートレート表示 [project-s] キャラクターメニューおよび全身ポートレート表示 Jan 24, 2024
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!
キャラクターメニューボタンの表示、とても見やすく感じました!

src/components/Sing/ScoreSequencer.vue Outdated Show resolved Hide resolved
src/components/Sing/CharacterPortrait.vue Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member

(あっ、windowsのテストが落ちてるのはスクショテストなので一旦スルーしていただけると・・・!)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit bf9f368 into project-s Jan 25, 2024
15 of 16 checks passed
@sevenc-nanashi sevenc-nanashi deleted the feature/1696_character_fullbody branch July 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants