[project-s] エンジン起動をApp.vueに移管 #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Jan 22, 2024
Comment on lines
+5
to
+11
| <keep-alive> | ||
| <component | ||
| :is="Component" | ||
| :is-engines-ready="isEnginesReady" | ||
| :project-file-path="projectFilePath" | ||
| /> | ||
| </keep-alive> |
There was a problem hiding this comment.
KeepAliveがないと中のコンポーネントのstateが消えるので「読み込み中」などが一瞬ちらつく。
ちなみにKeepAliveはvue-routerではなくVueの機能。
Hiroshiba
commented
Jan 22, 2024
| // ソフトウェアを初期化 | ||
| const isCompletedInitialStartup = ref(false); | ||
| const unwatchIsEnginesReady = watch( | ||
| // TODO: 最初に１度だけ実行している。Vueっぽくないので解体する |
There was a problem hiding this comment.
ここでやってる処理はこの３つ。
- プロジェクトが指定されてたら読み込む
- されてなかったら１個だけAudioCell作る
- ダイアログを表示する
１と３はApp.vueに移管できる。
２はEditorHomeのonMountedで実行すれば良く、「AudioCellが１つもなかったら１つ足す」処理をunmountedに書いて、App.vueの準備が整ったらEditorHomeをv-ifで表示してあげれば良いんだけど、そうするとショートカットキーの登録が間に合わない･･･。
|
こちらマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
エンジン起動をEditorHomeからApp.vueに移管します。
あとはメニューバーの移管して、切り替えをメニューバーへ移動させたらmainにマージしても大丈夫なはず！
関連 Issue
その他
どなたか見てほしいけど難しそう。ちょっと時間おいてえいやでマージしようと思います。