コンポーネント群の修正 #1681
Merged
コンポーネント群の修正 #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Dec 29, 2023
|
@Hiroshiba コメントありがとうございます！
|
|
@Hiroshiba コンポーネント群の修正完了しました！ |
Hiroshiba
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
ref #1513
スクリーンショット・動画など
変更前後で挙動に変動がないことを確認
number型のためundefinedになることはないが、既存実装を優先して
==に修正変更前後で挙動に変動がないことを確認
変更前後で挙動に変動がないことを確認
変更前後で挙動に変動がないことを確認
変更前後で挙動に変動がないことを確認
==で挙動上問題なし変更前後に挙動に変動がないことを確認
変更前後に挙動に変動がないことを確認
ref参照によりundefinedの可能性があるが、基本10個のボタンが選択されるため、挙動自体に問題なし
変更前後で挙動に変動がないことを確認
変更前後で挙動に変動がなく正常にことを確認