[project-s] スナップ周りの修正とリファクタリング #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Oct 21, 2023
Hiroshiba
reviewed
Oct 21, 2023
src/views/SingerHome.vue
Outdated
| if (store.state.score === undefined) { | ||
| const emptyScore = await store.dispatch("GET_EMPTY_SCORE"); | ||
| await store.dispatch("SET_SCORE", { score: emptyScore }); | ||
| } | ||
| await store.dispatch("SET_SCORE", {}); |
There was a problem hiding this comment.
すごい細かい部分なのですが･･･
無を渡すと初期化されるsetterは結構珍しめかもと思いました！
以前のコードは空っぽのオブジェクトを作ってセットするということがわかりやすいのですが、変更後のコードは何をしているのか把握するために一度SET_SCOREの実装を見る必要があるかも･･･？
There was a problem hiding this comment.
こちら、createEmptyScore関数で空のスコアを作成し、scoreの初期値として設定する形に変更しました！
（初期化（プロジェクトの初期値の設定）は「新規作成」のactionを呼び出して行った方が良いかも…？）
There was a problem hiding this comment.
なるほどです！！
確かに将来的には新規作成するメニューアイテムとか作りそうですもんね！
ちょっと今回は一旦スピード重視ということでマージさせていただきます！ 🙇
Hiroshiba
approved these changes
Oct 21, 2023
|
マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
ScoreSequencer.vueのリファクタリングsingHelper.tsのリファクタリングGET_EMPTY_SCOREを削除SET_SCOREの変更・リファクタリングSET_TEMPO、REMOVE_TEMPOのリファクタリングSET_TIME_SIGNATURE、REMOVE_TIME_SIGNATUREのリファクタリングPOSITION_TO_TIMEをTICK_TO_SECONDに変更TIME_TO_POSITIONをSECOND_TO_TICKに変更関連 Issue
VOICEVOX/voicevox_project#15
その他