Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] 拍の線を描画する処理を追加 #1607

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

sigprogramming
Copy link
Contributor

@sigprogramming sigprogramming commented Oct 14, 2023

内容

拍の線を描画する処理を追加します。

グリッドセルを描画するエリアの上に、小節・拍の線を描画するエリアを重ねています。
グリッドセル(スナップの線)と小節・拍の線を別々に描画し、
拍子が3/4、スナップが1/4(三連符)の場合でも適切に描画されるようにします。

関連 Issue

VOICEVOX/voicevox_project#15

スクリーンショット・動画など

スクリーンショット3

その他

  • スナップを設定する機能もこの後実装します

@sigprogramming sigprogramming requested a review from a team as a code owner October 14, 2023 09:35
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

いつかGUIと名称の対応マップ一覧を作りたいですね!
measure、beat等々。

@Hiroshiba Hiroshiba merged commit 1aa007d into VOICEVOX:project-s Oct 14, 2023
@sigprogramming sigprogramming deleted the draw_beat_line branch October 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants