[project-s] エンジンプロトタイプでレンダリングできるようにする #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
commented
Oct 3, 2023
Comment on lines
+988
to
1002
| // 母音の後ろに子音がある場合 | ||
| mora.vowelLength = noteLength - nextMora.consonantLength; | ||
| if (mora.vowelLength < minVowelLength) { | ||
| // 母音をこれ以上短くできない場合は、子音を短くする | ||
| mora.vowelLength = minVowelLength; | ||
| nextMora.consonantLength = noteLength - mora.vowelLength; | ||
| if (nextMora.consonantLength < minConsonantLength) { | ||
| // 子音も短くできない場合は、比で母音と子音の長さを決定する | ||
| const minMoraLength = minVowelLength + minConsonantLength; | ||
| const vowelRatio = minVowelLength / minMoraLength; | ||
| const consonantRatio = minConsonantLength / minMoraLength; | ||
| mora.vowelLength = noteLength * vowelRatio; | ||
| nextMora.consonantLength = noteLength * consonantRatio; | ||
| } | ||
| } |
There was a problem hiding this comment.
母音＋子音の長さがノートの長さを超えないようにします。
There was a problem hiding this comment.
コメントが適量書いてあってものすごい読みやすかったです！！
かなり単純な調整だと思うのですがちょっと触ってみてかなり十分に感じました。すごい。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
エンジンプロトタイプでレンダリングできるようにします。
また、無声化を解除する処理の追加や、母音・子音の長さを編集する処理の修正などを行います。
OpenAPI Generatorの実行と、
singing.ts、type.tsの編集を行っています。関連 Issue
VOICEVOX/voicevox_project#15
VOICEVOX/voicevox_engine#712
その他