-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[project-s] 歌ボ形式で歌声合成する機能を追加 #1255
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
573b078
歌ボ形式で歌声合成する機能を追加
sigprogramming 04e2ac2
リファクタリング
sigprogramming 6ffbbb3
修正とリファクタリング
sigprogramming fcade9a
Update src/store/singing.ts
sigprogramming 1e3c514
logInfoでログ出力するように変更、テキストではなく音素を出力するように変更
sigprogramming 6be707e
Merge branch 'utavo' of https://github.com/sigprogramming/voicevox in…
sigprogramming 520f655
修正とリファクタリング、コメントの追加
sigprogramming 6853ad6
audioQueryCacheを削除、リファクタリングとコメントの追加
sigprogramming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです、設計がなんとなく見えてきた気がします!
AudioSequenceがAudioPlayerを持つ設計ではなく、AudioSequenceを持つ誰かがAudioPlayerを1つだけ持つ設計にすると、Playerが散らばらずに1箇所に集まるので管理しやすい・・・かも・・・・・?
いやでも一様に扱えるので今の設計もありかも・・・?
まあ設計をガチャガチャ変えながら実装するよりも、一旦とりあえず全部実装してみてあとで整理して再設計するのが良いのかなと思いました。
なのでとりあえず問題なく動いているなら今は一旦良し・・・!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transportで全てのイベントのスケジューリングを行うためにこの形になっていますが、私も「AudioSequenceを持つ誰かがAudioPlayerを1つだけ持つ」形のほうが自然な気がするので、後でまた設計を検討・試行したいと思います!
おそらく「AudioSequenceを持つ誰か」がそれぞれスケジューリングを行うことになり、そのスケジューリングの実行をTransportが管理することになると思います。
(一応今の設計でもループやマルチトラックの実装は可能です)