Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
モーフィング機能の制限に対応 #1128
モーフィング機能の制限に対応 #1128
Changes from 9 commits
0a39ad8
54b9f70
ccd7ce0
fe4ce2d
6610d36
abeb88f
8972ffa
118d59e
5d2c8db
0d9f690
26301f0
0f48143
9c9248f
2e021e4
341b019
28dc043
69f5df4
7d8b69a
2caa1ef
4d77182
b9978bc
5ab2bbd
5671c6b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もう1つUXレベルの判断です。 (実装してくださった @sabonerune さんの感謝も込めて・・・! )
今まででは全キャラ全スタイルが表示されていたのが、ここで可能なキャラだけになります。
そもそもですが、ボイボは8割のキャラが8割のキャラとモーフィング可能で、2割のキャラはほぼ不可となりそうです。
仕様としてどの形が良いか考えてみました。
最高なのはこうだと思います。
このパターンだと3番目の選択不可能な理由を書けるUIの用意が大変だと思いました。
次はこうかなと思います。
理由の表示はここのUIでできるとベターだと思いますが、なかなか案内が難しそうに感じます。
良い方法がない場合はQ&A+使い方で案内が良いかなと思いました。
なぜ全キャラを選択できるUIが厳しいのかというと、全キャラが選択不可能なキャラもいることがわかったためです。
このキャラを選んでいた場合の運の悪いユーザーのパターンだと、全キャラの選択を試して、全キャラダメだったとわかるというなかなかしんどそうなUXになってしまうためです。
元のUIがよくないわけではなく、想定が変わったことが今回の判断の変更理由になります。
もっと良い形もあるかもしれません、アイデア募集しています・・・!!!
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.