Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cfg(not(feature = "download-binaries"))のビルドを直す #9

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 13, 2024

内容

cfg(not(feature = "download-binaries"))でのビルドが壊れてたので直します。

error: couldn't read /home/ryo/src/github.com/VOICEVOX/voicevox_core/main/target/release/build/voicevox-ort-sys-054fe364665b3fd2/out/downloaded_version.rs: No such file or directory (os error 2)
 --> /home/ryo/.cargo/git/checkouts/ort-d0492e4da5dd1ef1/8627833/ort-sys/src/internal/mod.rs:3:1
  |
3 | include!(concat!(env!("OUT_DIR"), "/downloaded_version.rs"));
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the macro `include` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `voicevox-ort-sys` (lib) due to 1 previous error

現段階では何かの支障になっているわけではないのですが、意図に反して壊れている状態ではあるので一応。
(「現段階では」というのは、voicevox_core/load-onnxruntimeでもlibonnxruntimeが自動ダウンロードされるのは無駄、という判断もできそうなため)

関連 Issue

スクリーンショット・動画など

その他

@qryxip qryxip requested a review from Hiroshiba September 23, 2024 09:55
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

レビューリクエスト助かりました!!

@Hiroshiba Hiroshiba merged commit 69ac04c into VOICEVOX:main Sep 24, 2024
7 checks passed
@Hiroshiba
Copy link
Member

あっすみませんマージしてしまいました!!
こちらもマージお任せした方が良さそうですよね、意識します🙇

qryxip added a commit to VOICEVOX/voicevox_core that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants