Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iOS #9

Merged
merged 10 commits into from
Apr 2, 2023
Merged

Support iOS #9

merged 10 commits into from
Apr 2, 2023

Conversation

HyodaKazuaki
Copy link
Contributor

@HyodaKazuaki HyodaKazuaki commented Mar 31, 2023 •
edited
Loading

iOS向けのビルドを作る機能を追加します。

Intel MacのiPhone simulator上で動作するx86_64-apple-iosをターゲットとしたビルドは含まれません。

Hiroshiba
Hiroshiba reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

crates/open_jtalk-sys/build.rs Outdated Show resolved Hide resolved
crates/open_jtalk-sys/src/generated/bindings.rs Show resolved Hide resolved
@HyodaKazuaki HyodaKazuaki mentioned this pull request Apr 1, 2023
Closed
PickledChair
PickledChair requested changes Apr 2, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手元の環境で generate-bindings が上手く動くことを確認しました！

いくつかより良くできそうな部分があったのでコメントしました。

crates/open_jtalk-sys/build.rs Outdated Show resolved Hide resolved
crates/open_jtalk-sys/build.rs Outdated Show resolved Hide resolved
crates/open_jtalk-sys/build.rs Show resolved Hide resolved
@HyodaKazuaki HyodaKazuaki mentioned this pull request Apr 2, 2023
Closed
6 tasks
PickledChair
PickledChair approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

voicevox_core の iOS 対応に向けて一歩ずつ進めていけそうですね。ありがとうございました！

Hiroshiba
Hiroshiba approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

PRありがとうございました！！

@Hiroshiba Hiroshiba merged commit 589a216 into VOICEVOX:main Apr 2, 2023
This was referenced Apr 3, 2023
Merged
Merged
@Hiroshiba Hiroshiba mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PickledChair PickledChair PickledChair approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HyodaKazuaki @Hiroshiba @PickledChair