Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1890 ✨ Expand parameter for Zaken endpoint #207

Merged
merged 4 commits into from
Nov 30, 2021
Merged

#1890 ✨ Expand parameter for Zaken endpoint #207

merged 4 commits into from
Nov 30, 2021

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Nov 16, 2021 •
edited
Loading

issue: VNG-Realisatie/gemma-zaken#1890

Changes:

  • Add fields rollen, zaakobjecten and zaakinformatieobjecten to Zaak resource
  • Add expand query parameter to expand to following fields:
    • Zaak.status
    • Zaak.resultaat
    • Zaak.eigenschappen
    • Zaak.rollen
    • Zaak.zaakobjecten
    • Zaak.zaakinformatieobjecten

@stevenbal stevenbal marked this pull request as draft November 16, 2021 15:21
@stevenbal stevenbal changed the base branch from master to feature/1892-zaken-extra-ordering November 16, 2021 15:21
@stevenbal stevenbal force-pushed the feature/1890-zaken-expand branch from 0f438c6 to ba76366 Compare November 19, 2021 08:54
@stevenbal stevenbal changed the title [WIP] Feature/1890 zaken expand [WIP] #1890 ✨ Expand parameter for Zaken endpoint Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021 •
edited
Loading

Codecov Report

Merging #207 (ba76366) into feature/1892-zaken-extra-ordering (5c2c6c7) will increase coverage by 0.07%.
The diff coverage is 92.67%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/1892-zaken-extra-ordering     #207      +/-   ##
=====================================================================
+ Coverage                              93.67%   93.74%   +0.07%     
=====================================================================
  Files                                    201      202       +1     
  Lines                                   7648     7848     +200     
  Branches                                 312      333      +21     
=====================================================================
+ Hits                                    7164     7357     +193     
- Misses                                   415      418       +3     
- Partials                                  69       73       +4
Impacted Files Coverage Δ
src/zrc/utils/serializers.py 77.41% <77.41%> (ø)
src/zrc/api/serializers/core.py 93.22% <86.20%> (+0.09%) ⬆️
src/zrc/api/filters.py 100.00% <100.00%> (ø)
src/zrc/api/tests/test_zaken.py 100.00% <100.00%> (ø)
src/zrc/api/viewsets.py 93.68% <100.00%> (+0.19%) ⬆️
src/zrc/datamodel/models/core.py 97.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2c6c7...ba76366. Read the comment docs.

@stevenbal stevenbal changed the title [WIP] #1890 ✨ Expand parameter for Zaken endpoint #1890 ✨ Expand parameter for Zaken endpoint Nov 19, 2021
@stevenbal stevenbal marked this pull request as ready for review November 19, 2021 09:58
alextreme
alextreme approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prima wat mij betreft, aan Michiel om te bepalen of dit in de standaard mag voor de ZRC

@stevenbal stevenbal mentioned this pull request Nov 23, 2021
Closed
2 tasks
Base automatically changed from feature/1892-zaken-extra-ordering to master November 30, 2021 13:35
@michielverhoef michielverhoef merged commit 4de09c1 into master Nov 30, 2021
@michielverhoef michielverhoef deleted the feature/1890-zaken-expand branch November 30, 2021 13:35
@alextreme alextreme mentioned this pull request May 8, 2022
Closed
SonnyBA pushed a commit that referenced this pull request Jul 5, 2022
Revert "Merge pull request #207 from VNG-Realisatie/feature/1890-zake…
8b490b4 
…n-expand"

This reverts commit 4de09c1, reversing
changes made to 062ec15.
SonnyBA pushed a commit that referenced this pull request Jul 5, 2022
Revert "Merge pull request #207 from VNG-Realisatie/feature/1890-zake…
3e5a4e6 
…n-expand"

This reverts commit 4de09c1, reversing
changes made to 062ec15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@michielverhoef michielverhoef Awaiting requested review from michielverhoef

@SonnyBA SonnyBA Awaiting requested review from SonnyBA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenbal @codecov-commenter @alextreme @michielverhoef