Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popper): add prop strategy #8178

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Release notes

Изменения

Добавил свойство strategy в Popper и прокинул в useFloating

Release notes

Улучшения

  • Popper: Добавлено свойство strategy

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner January 23, 2025 13:36
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 392.47 KB (+0.02% 🔺)
JS (gzip) 119.04 KB (+0.02% 🔺)
JS (brotli) 97.95 KB (-0.05% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 344.21 KB (0%)
CSS (gzip) 42.66 KB (0%)
CSS (brotli) 33.99 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c34a5f2

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (fda620d) to head (c34a5f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8178   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         403      403           
  Lines       11457    11458    +1     
  Branches     3783     3784    +1     
=======================================
+ Hits        10941    10942    +1     
  Misses        516      516           
Flag Coverage Δ
unittests 95.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 7bd4edc into master Jan 24, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8175/popper-strategy-prop branch January 24, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Strategy проп для Popper
3 participants