Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ModalRoot): add info about wrappers of modals #8100

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

inomdzhon
Copy link
Contributor

Описание

В #6759 пропустил момент про обёртки.

Release notes

Документация

  • ModalRoot: добавлен FAQ с информацией как создавать обёртки над ModalPage и ModalCard
  • В документе Миграция с v6 на v7 дополнена секция ModalRoot информацией касаемой обёртки над ModalPage / ModalCard

@inomdzhon inomdzhon added docs patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Dec 18, 2024
@inomdzhon inomdzhon self-assigned this Dec 18, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner December 18, 2024 09:51
@inomdzhon inomdzhon added this to the v7.0.1 milestone Dec 18, 2024
Copy link

codesandbox-ci bot commented Dec 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (b5f950e) to head (caa6e69).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8100   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11326    11326           
  Branches     3731     3731           
=======================================
  Hits        10822    10822           
  Misses        504      504           
Flag Coverage Δ
unittests 95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 446b1cd into master Dec 18, 2024
19 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/ModalRoot-docs branch December 18, 2024 12:41
vkcom-publisher pushed a commit that referenced this pull request Dec 18, 2024
h2. Описание

В #6759 пропустил момент про обёртки.

h2. Release notes
h2. Документация
- ModalRoot: добавлен **FAQ** с информацией как создавать обёртки над `ModalPage` и `ModalCard`
- В документе **Миграция с v6 на v7** дополнена секция `ModalRoot` информацией касаемой обёртки над `ModalPage` / `ModalCard`
@vkcom-publisher
Copy link
Contributor

v7.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants