temporary open for tester off

[phatna03]

1. Related Tickets

• Github#TicketID

2. What's this PR do?

3. Checklist (If you won't pass this checklist please comment why)

• Build successfully on local.
• I removed all commented or unnecessary code.
• Update the PR URL into related tickets.
• Note the reason, scope of influence, and solution into ticket.
• My code has covered these test cases (please list down your tested cases):

4. Screenshots

(screenshots)

5. Notes

(notes)

Summary by CodeRabbit

• New Features
  • Enhanced navigation by updating the "Dashboard" link to point directly to the dashboard.
• Bug Fixes
  • Improved security and user experience by fixing the redirection logic in the admin panel to correctly identify admin users and redirect accordingly.

[coderabbitai]

Walkthrough

The updates focus on refining the navigation and security within an admin panel. A navigation link has been corrected to point users towards the "Dashboard" instead of "Campaigns". Additionally, enhancements in security logic ensure that only users with admin privileges can access certain areas, streamlining the access control process by simplifying the admin role verification.

Changes

File Path	Change Summary
.../LayoutHeader/index.tsx	Changed link from AdminPaths.CAMPAIGNS to AdminPaths.DASHBOARD for "Dashboard".
.../hocs/RouterGuard.tsx	Uncommented isAdmin check; adjusted redirection for user permissions.
.../utils/permission.ts	Simplified isAdmin function to check for admin role only.

🐇✨
Changes here and changes there,
Dashboard links in the open air.
Security tight, with access fair,
Only for admin eyes to glare.
In code we trust, in change we dare.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cedf1a6 and c51b82f.

Files selected for processing (3)

• packages/admin/src/components/LayoutHeader/index.tsx (1 hunks)
• packages/admin/src/hocs/RouterGuard.tsx (2 hunks)
• packages/admin/src/utils/permission.ts (1 hunks)

Additional comments: 3

packages/admin/src/hocs/RouterGuard.tsx (2)

• 46-48: The addition of the isAdmin check is a good enhancement for security. Ensure that this check aligns with the application's overall permission and access control strategy.
• 55-61: The redirection logic is clear, but consider adding a specific error message or logging when redirection occurs due to failed admin checks or errors. This can improve debugging and user experience by providing more context on why a redirection happened.

packages/admin/src/components/LayoutHeader/index.tsx (1)

• 73-73: The change in the navigation link from campaigns to the dashboard is consistent with the PR's objectives. Ensure that this change is reflected across all instances where the "Dashboard" link is used and verify that it does not disrupt any existing navigation flows.

[coderabbitai]

The simplification of the isAdmin function looks good. However, consider adding a nullish check for user.roles to ensure robustness, especially if there's any chance that user.roles might be undefined or null in some cases.

-  return user.roles && user.roles.includes(RoleEnum.ADMIN);
+  return user.roles?.includes(RoleEnum.ADMIN);

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	return user.roles && user.roles.includes(RoleEnum.ADMIN);
	return user.roles?.includes(RoleEnum.ADMIN);