Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show campaign total supply NFT #126

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

0xkynz
Copy link
Collaborator

@0xkynz 0xkynz commented Dec 27, 2023

Summary by CodeRabbit

  • Enhancements

    • Improved the CampaignDetail component to enhance the display and conditions for rendering campaign-specific information.
  • New Features

    • Campaign status is now more accurately represented using the CampaignStatusEnum.
  • User Interface

    • Updated NFT collection details to provide clearer information about the associated broker.

Copy link

coderabbitai bot commented Dec 27, 2023

Walkthrough

The recent updates involve adjustments to the CampaignDetail component's display logic, particularly in how it handles and presents NFT collection details, with a focus on properties related to the collection's broker. The code now also incorporates the CampaignStatusEnum to better manage campaign statuses, indicating a refinement in the component's state management and user interface.

Changes

File Path Change Summary
.../campaign/campaign-detail/index.tsx Adjusted rendering logic and control flow, updated NFT collection detail display, and imported CampaignStatusEnum.

🐇✨
In the realm of code, where details dance and sway,
A rabbit hopped through, refining the display.
With enums in hand, and logic set right,
The campaign details now shine ever so bright.
🌟📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file
    • @coderabbitai modularize this function
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai gather interesting statistics about this repository and render them in a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@0xkynz 0xkynz merged commit dc9fa2b into develop Dec 27, 2023
1 check passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ded30b2 and 4140ea8.
Files selected for processing (1)
  • packages/user/src/modules/campaign/campaign-detail/index.tsx (3 hunks)
Additional comments: 3
packages/user/src/modules/campaign/campaign-detail/index.tsx (3)
  • 11-11: The import of CampaignStatusEnum is correctly placed and follows the existing import structure. Ensure that the imported enum is used consistently throughout the component.

  • 104-107: The conditional rendering logic using CampaignStatusEnum.RUNNING is appropriate and follows best practices for readability and maintainability.

  • 126-167: The new conditional block for rendering nftCollection.broker details is well-structured and follows the existing coding patterns. However, ensure that the hardcoded value 99 in line 135 is intentional and consistent with the application's requirements.

0xkynz added a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant