extend goto/implementation to find architectures of entities #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the find_implementation function to also search for architectures if the base designator is an entity
kraigher
requested changes
Nov 27, 2023
vhdl_lang/src/analysis/root.rs
Outdated
| AnyEntKind::Design(Design::Architecture(a)) => { | ||
| matches!( | ||
| a.designator(), | ||
| Designator::Identifier(ent_ident) if ent_ident == ident |
There was a problem hiding this comment.
For the entity/architecture pair we can compare the id instead of comparing the names:
AnyEntKind::Design(Design::Architecture(ent_of_arch)) => ent_of_arch== ent, Comparing the id:s is faster and more precise even though entities are guaranteed to have unique names within a library.
compare entity and entity of the architecture by their ids
|
Looks good, you just forgot to run cargo fmt |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've extended the find_implementation function to also search for architectures which implement an entity.