forked from apache/incubator-hugegraph
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: optimize perf for adjacency-edges query (apache#2242)
- Loading branch information
Showing
4 changed files
with
158 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...ver/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/EdgeExistenceAPI.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with this | ||
| * work for additional information regarding copyright ownership. The ASF | ||
| * licenses this file to You under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.hugegraph.api.traversers; | ||
|
|
||
| import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_LIMIT; | ||
|
|
||
| import java.util.Iterator; | ||
|
|
||
| import org.apache.hugegraph.HugeGraph; | ||
| import org.apache.hugegraph.backend.id.Id; | ||
| import org.apache.hugegraph.core.GraphManager; | ||
| import org.apache.hugegraph.structure.HugeVertex; | ||
| import org.apache.hugegraph.traversal.algorithm.EdgeExistenceTraverser; | ||
| import org.apache.hugegraph.util.E; | ||
| import org.apache.hugegraph.util.Log; | ||
| import org.apache.tinkerpop.gremlin.structure.Edge; | ||
| import org.slf4j.Logger; | ||
|
|
||
| import com.codahale.metrics.annotation.Timed; | ||
|
|
||
| import io.swagger.v3.oas.annotations.Operation; | ||
| import io.swagger.v3.oas.annotations.tags.Tag; | ||
| import jakarta.inject.Singleton; | ||
| import jakarta.ws.rs.DefaultValue; | ||
| import jakarta.ws.rs.GET; | ||
| import jakarta.ws.rs.Path; | ||
| import jakarta.ws.rs.PathParam; | ||
| import jakarta.ws.rs.Produces; | ||
| import jakarta.ws.rs.QueryParam; | ||
| import jakarta.ws.rs.core.Context; | ||
|
|
||
| @Path("graphs/{graph}/traversers/edgeexist") | ||
| @Singleton | ||
| @Tag(name = "EdgeExistenceAPI") | ||
| public class EdgeExistenceAPI extends TraverserAPI { | ||
|
|
||
| private static final Logger LOG = Log.logger(EdgeExistenceAPI.class); | ||
| private static final String DEFAULT_EMPTY = ""; | ||
|
|
||
| @GET | ||
| @Timed | ||
| @Produces(APPLICATION_JSON_WITH_CHARSET) | ||
| @Operation(summary = "get edges from 'source' to 'target' vertex") | ||
| public String get(@Context GraphManager manager, | ||
| @PathParam("graph") String graph, | ||
| @QueryParam("source") String source, | ||
| @QueryParam("target") String target, | ||
| @QueryParam("label") String edgeLabel, | ||
| @QueryParam("sort_values") | ||
| @DefaultValue(DEFAULT_EMPTY) String sortValues, | ||
| @QueryParam("limit") | ||
| @DefaultValue(DEFAULT_LIMIT) long limit) { | ||
| LOG.debug("Graph [{}] get edgeExistence with " + | ||
| "source '{}', target '{}', edgeLabel '{}', sortValue '{}', limit '{}'", | ||
| graph, source, target, edgeLabel, sortValues, limit); | ||
|
|
||
| E.checkArgumentNotNull(source, "The source can't be null"); | ||
| E.checkArgumentNotNull(target, "The target can't be null"); | ||
|
|
||
| Id sourceId = HugeVertex.getIdValue(source); | ||
| Id targetId = HugeVertex.getIdValue(target); | ||
| HugeGraph hugegraph = graph(manager, graph); | ||
| EdgeExistenceTraverser traverser = new EdgeExistenceTraverser(hugegraph); | ||
| Iterator<Edge> edges = traverser.queryEdgeExistence(sourceId, targetId, edgeLabel, | ||
| sortValues, limit); | ||
|
|
||
| return manager.serializer(hugegraph).writeEdges(edges, false); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...h-core/src/main/java/org/apache/hugegraph/traversal/algorithm/EdgeExistenceTraverser.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with this | ||
| * work for additional information regarding copyright ownership. The ASF | ||
| * licenses this file to You under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.hugegraph.traversal.algorithm; | ||
|
|
||
| import java.util.Iterator; | ||
|
|
||
| import org.apache.hugegraph.HugeGraph; | ||
| import org.apache.hugegraph.backend.id.Id; | ||
| import org.apache.hugegraph.backend.query.ConditionQuery; | ||
| import org.apache.hugegraph.iterator.FilterIterator; | ||
| import org.apache.hugegraph.schema.EdgeLabel; | ||
| import org.apache.hugegraph.type.HugeType; | ||
| import org.apache.hugegraph.type.define.Directions; | ||
| import org.apache.hugegraph.type.define.HugeKeys; | ||
| import org.apache.tinkerpop.gremlin.structure.Edge; | ||
|
|
||
| public class EdgeExistenceTraverser extends HugeTraverser { | ||
|
|
||
| public EdgeExistenceTraverser(HugeGraph graph) { | ||
| super(graph); | ||
| } | ||
|
|
||
| public Iterator<Edge> queryEdgeExistence(Id sourceId, Id targetId, String label, | ||
| String sortValues, long limit) { | ||
| // If no label provided, fallback to a slow query by filtering | ||
| if (label == null || label.isEmpty()) { | ||
| return queryByNeighbors(sourceId, targetId, limit); | ||
| } | ||
|
|
||
| Id edgeLabelId = getEdgeLabelId(label); | ||
| EdgeLabel edgeLabel = graph().edgeLabel(edgeLabelId); | ||
| ConditionQuery conditionQuery = new ConditionQuery(HugeType.EDGE); | ||
| conditionQuery.eq(HugeKeys.OWNER_VERTEX, sourceId); | ||
| conditionQuery.eq(HugeKeys.OTHER_VERTEX, targetId); | ||
| conditionQuery.eq(HugeKeys.LABEL, edgeLabelId); | ||
| conditionQuery.eq(HugeKeys.DIRECTION, Directions.OUT); | ||
| conditionQuery.limit(limit); | ||
|
|
||
| if (edgeLabel.existSortKeys()) { | ||
| conditionQuery.eq(HugeKeys.SORT_VALUES, sortValues); | ||
| } else { | ||
| conditionQuery.eq(HugeKeys.SORT_VALUES, ""); | ||
| } | ||
| return graph().edges(conditionQuery); | ||
| } | ||
|
|
||
| private Iterator<Edge> queryByNeighbors(Id sourceId, Id targetId, long limit) { | ||
| return new FilterIterator<>(edgesOfVertex(sourceId, Directions.OUT, (Id) null, limit), | ||
| edge -> targetId.equals(edge.inVertex().id())); | ||
| } | ||
| } |