Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch bins to closed on left #253

Merged
merged 3 commits into from
Mar 18, 2024
Merged

switch bins to closed on left #253

merged 3 commits into from
Mar 18, 2024

Conversation

d-callan
Copy link
Member

@d-callan d-callan requested a review from asizemore March 18, 2024 15:00
asizemore
asizemore approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@asizemore asizemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was an issue only with the integers?

@d-callan
Copy link
Member Author

yes and no.. the integers and dates where bin width was 1 made it obvious, bc there was only a single value in the starting bin and it wasnt the value the label in the plot showed.

@d-callan d-callan merged commit 30a495d into main Mar 18, 2024
5 checks passed
@d-callan d-callan deleted the bins-closed-left branch March 18, 2024 16:39
@bobular bobular mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asizemore asizemore asizemore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need better handling of x-axis labels of Line plots & timeline plots
2 participants
@d-callan @asizemore