Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should depth/quality plots include anomalous read pairs? #112

Open
averagehat opened this issue Mar 24, 2015 · 5 comments
Open

Should depth/quality plots include anomalous read pairs? #112

averagehat opened this issue Mar 24, 2015 · 5 comments

Comments

@averagehat
Copy link
Contributor

Currently the bam_to_qualdepth module uses the bdq.mpileup method to generate the depth+quality plots. By default, samtools mpileup ignores "orphaned" or "anomalous" reads (those are paired reads where the mate is not paired). Should we add the "-A" flag to the command to include the anomalous reads?

@necrolyte2 necrolyte2 modified the milestone: v1.2.0 Mar 24, 2015
@necrolyte2
Copy link
Member

@mmelendrez will have to answer that one

I could see it going either way as the bqd.mpileup is a duplicate function almost to the samtools.mpileup

Migration is still needed to move any existing code using bqd.mpileup over to samtools.mpileup.
Regardless, we should probably decide if we should be using the -A flag as neither function use it currently.

@necrolyte2 necrolyte2 modified the milestone: v1.3.0 Jun 12, 2015
@averagehat
Copy link
Contributor Author

This will be a config option with the default set to "no orphans"

@necrolyte2
Copy link
Member

Should we make it so that it makes more sense such as
include_orphans: yes|true|no|false and defaults to no

@averagehat
Copy link
Contributor Author

yes

@averagehat
Copy link
Contributor Author

I don't think this is really a filter issue, this is a flag that we might add to the base caller/plotting scripts. Dropping the filter milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants