widget_3d_tiles: the integrated layer manager is now optional. #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {itowns.View} view - The view to which the layer will be added | ||
| * @param {itowns.C3DTilesLayer} layer - layer to be added to dom element | ||
| * @param {HTMLDivElement} layersContainer - HTML division holding the listed layers | ||
| * @param {string} layerContainerClassName - Class name of the layer container |
There was a problem hiding this comment.
layerContainer is optional the JSDOC syntax is:
* @param {string} [layerContainerClassName] - Class name of the layer container
| // Available layers are optionnaly listed in the UI. Inhibiting this display | ||
| // allows for an alternative usage of other widgets with a similar purpose | ||
| // but different feature e.g. @ud-viz/widget_layer_choice. | ||
| if (typeof options.displayExistingLayers == 'undefined') { |
There was a problem hiding this comment.
The operator typeof is not required in this condition:
if(options.displayExistingLayers == undefined)
or
if(!options.displayExistingLayers)
mathieuLivebardon
approved these changes
Apr 16, 2024
EricBoix
force-pushed
the
widget_3dtiles_optionnal_layer_manager
branch
from
21c039b
to
c46e838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments also added.