Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update:EventSender -> THREE.EventDispatcher #732

Merged
merged 2 commits into from
Sep 12, 2023
Merged

update:EventSender -> THREE.EventDispatcher #732

merged 2 commits into from
Sep 12, 2023

Conversation

mathieuLivebardon
Copy link
Contributor

This PR remove EventSender class and replace it by EventDispatcher of threejs library.

@mathieuLivebardon mathieuLivebardon linked an issue Sep 12, 2023 that may be closed by this pull request
Replace EventSender by THREE.EventDispatcher #561
Closed
@mathieuLivebardon mathieuLivebardon self-assigned this Sep 12, 2023
@valentinMachado valentinMachado merged commit dafee07 into master Sep 12, 2023
3 checks passed
@valentinMachado valentinMachado deleted the 561-replace-eventsender-by-threeeventdispatcher branch September 12, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinMachado valentinMachado valentinMachado approved these changes

Assignees

@mathieuLivebardon mathieuLivebardon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace EventSender by THREE.EventDispatcher
2 participants
@mathieuLivebardon @valentinMachado