Documentation #722
Merged
Documentation #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuLivebardon
requested review from
valentinMachado,
LorenzoMarnat and
EricBoix
bin/backEnd.js
Outdated
| /** | ||
| * @file Sets up an Express backend server for examples, serving static files, | ||
| * replacing HTML strings, and enabling a game socket service. | ||
| * The behavior adapts based on the environment mode and uses package.json configuration. |
There was a problem hiding this comment.
maybe you could refer to cross-env to explain the environment mode like => see cross-env
bin/prePublish.js
Outdated
| console.log('Start reset'); | ||
| exec('npm run reset') | ||
| const commandReset = `npm run reset`; | ||
| console.log('RUN', commandReset); |
There was a problem hiding this comment.
instead of "RUN" "exec" seems more appropiate
bin/prePublish.js
Outdated
| `git describe --tags --match v* --abbrev=0 | xargs -I tag sh -c 'git log tag..HEAD --pretty=format:%s > ./docs/static/ChangelogDiff.txt'` | ||
| ).then(() => { | ||
| const commandGenerateChangelog = `git describe --tags --match v* --abbrev=0 | xargs -I tag sh -c 'git log tag..HEAD --pretty=format:%s > ./docs/static/ChangelogDiff.txt'`; | ||
| console.log('RUN', commandGenerateChangelog); |
LorenzoMarnat
approved these changes
Sep 4, 2023
| * @requires {@link https://www.npmjs.com/package/@ud-viz/shared|@ud-viz/shared} | ||
| * @requires {@link https://www.npmjs.com/package/reload|reload} | ||
| * @requires {@link https://www.npmjs.com/package/string-replace-middleware|string-replace-middleware} | ||
| * The behavior adapts based on the environment mode (NODE_ENV) inject in procosss.env with cross-env package. |
There was a problem hiding this comment.
I went too fast to merge the branch I had not seen the comment. I fixed it in this new PR. 😶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR which adds dome doc: