Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #637 - Setup & configure VCH plugin #643

Merged
merged 25 commits into from
Apr 12, 2024

Conversation

BenWalker01
Copy link
Contributor

@BenWalker01 BenWalker01 commented Jan 30, 2024

Fixes #637

Summary of changes

Added the relevant VCH plugin lists as below:
DEP - cleared for take-off flag, hold short dropdown, request, and pending request time
ARR - cleared to land flag, hold short dropdown, request, and pending request time
STUP - request and pending request time
TAXIOUT - hold short dropdown, request, and pending request time
TAKEOFF - cleared for take-off flag, hold short dropdown, request, and pending request time

Screenshots

image
image

@BenWalker01
Copy link
Contributor Author

BenWalker01 commented Jan 30, 2024

Should VCH now be loaded as default? If so I can add that.

@luke11brown
Copy link
Contributor

Should VCH now be loaded as default? If so I can add that.

Yes

@luke11brown
Copy link
Contributor

Also, If you could also update the README.md and README.docx linking the VCH GitHub, as with other plugins

@BenWalker01
Copy link
Contributor Author

BenWalker01 commented Feb 6, 2024

README.docx

Does the pdf need updating as well?

@luke11brown
Copy link
Contributor

README.docx

Does the pdf need updating as well?

PDF is generated from the docx every cycle, so no need.

@luke11brown
Copy link
Contributor

luke11brown commented Feb 22, 2024

Excellent work.

Just a couple of comments.

The lists defined in AC_General.txt need to be moved to Lists_Area.txt

The definitions for the lists are already there, so the .prf files just need to point at them for all lists, essentially all the new type lists have defaulted to the general file.
Settings SettingsfileSTUP \..\Data\Settings\Lists_SMR.txt
Settings SettingsfileTAXIOUT \..\Data\Settings\Lists_SMR.txt
Settings SettingsfileTAKEOFF \..\Data\Settings\Lists_SMR.txt

@luke11brown
Copy link
Contributor

luke11brown commented Feb 22, 2024

This pr will have a lot of conflicts with #413 when merged.

In this I have also sneaked in the fixes to #644

@BenWalker01
Copy link
Contributor Author

I can probably get to the area lists this afternoon/evening

#644 is all taken care of then in #413?

@BenWalker01
Copy link
Contributor Author

The lists defined in AC_General.txt need to be moved to Lists_Area.txt

Not sure I understand. Do you want the lists removing from AC_General.txt as they are mirrored in Lists_Area.txt.

The definitions for the lists are already there, so the .prf files just need to point at them for all lists, essentially all the new type lists have defaulted to the general file.

Settings SettingsfileSTUP ..\Data\Settings\Lists_SMR.txt
Settings SettingsfileTAXIOUT ..\Data\Settings\Lists_SMR.txt
Settings SettingsfileTAKEOFF ..\Data\Settings\Lists_SMR.txt

Is this for all the area .prf? Including the topsky?

@luke11brown
Copy link
Contributor

Not sure I understand. Do you want the lists removing from AC_General.txt as they are mirrored in Lists_Area.txt.

If the data is in Lists_Area.txt, then the list info in AC)General can be removed.

Is this for all the area .prf? Including the topsky?

Area will point to Lists_Area.txt
TopSky will point to Lists_TopSky.txt
SMRs will point to Lists_SMR.txt
APC profiles will point to Lists.txt

@BenWalker01
Copy link
Contributor Author

Should be good as per above. But let me know if anything else needs changing!

@luke11brown luke11brown self-requested a review March 24, 2024 06:24
Comment on lines 5 to +6
Settings Settingsfile \..\..\Data\Settings\AC\AC_General.txt
Settings SettingsfileARR \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileCONFLICT \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileDEP \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileFP \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileSEL \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileSIL \..\..\Data\Settings\Lists_TopSky.txt
Settings SettingsfileARR \..\Data\Settings\Lists_TopSky.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedstonePilot There is a difference between the spaces used here.

I believe ES needs a tab, rather than a space for these lines to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting it was a copy and paste and I just edited the path at the end. Guess something messed up. Will look when free.

Copy link
Contributor Author

@BenWalker01 BenWalker01 Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do some have \..\..\Data while some have only a single \..\?
Regarding the tab issues they look like tabs my end

@luke11brown
Copy link
Contributor

Also, Heathrow has separate list files which appear untouched.

@luke11brown luke11brown merged commit 2bd1ff0 into VATSIM-UK:main Apr 12, 2024
@BenWalker01 BenWalker01 deleted the issue-637 branch April 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup & configure VCH plugin
2 participants