-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #637 - Setup & configure VCH plugin #643
Conversation
Should VCH now be loaded as default? If so I can add that. |
Yes |
Also, If you could also update the README.md and README.docx linking the VCH GitHub, as with other plugins |
Does the pdf need updating as well? |
PDF is generated from the docx every cycle, so no need. |
Excellent work. Just a couple of comments. The lists defined in AC_General.txt need to be moved to Lists_Area.txt The definitions for the lists are already there, so the .prf files just need to point at them for all lists, essentially all the new type lists have defaulted to the general file. |
Not sure I understand. Do you want the lists removing from AC_General.txt as they are mirrored in Lists_Area.txt.
Is this for all the area .prf? Including the topsky? |
If the data is in Lists_Area.txt, then the list info in AC)General can be removed.
Area will point to Lists_Area.txt |
Should be good as per above. But let me know if anything else needs changing! |
Settings Settingsfile \..\..\Data\Settings\AC\AC_General.txt | ||
Settings SettingsfileARR \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileCONFLICT \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileDEP \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileFP \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileSEL \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileSIL \..\..\Data\Settings\Lists_TopSky.txt | ||
Settings SettingsfileARR \..\Data\Settings\Lists_TopSky.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RedstonePilot There is a difference between the spaces used here.
I believe ES needs a tab, rather than a space for these lines to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting it was a copy and paste and I just edited the path at the end. Guess something messed up. Will look when free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do some have \..\..\Data
while some have only a single \..\
?
Regarding the tab issues they look like tabs my end
Also, Heathrow has separate list files which appear untouched. |
Fixes #637
Summary of changes
Added the relevant VCH plugin lists as below:
DEP - cleared for take-off flag, hold short dropdown, request, and pending request time
ARR - cleared to land flag, hold short dropdown, request, and pending request time
STUP - request and pending request time
TAXIOUT - hold short dropdown, request, and pending request time
TAKEOFF - cleared for take-off flag, hold short dropdown, request, and pending request time
Screenshots