Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TopSky on TC/APP Displays #751

Closed
1 of 4 tasks
luke11brown opened this issue May 26, 2024 · 2 comments · Fixed by #771
Closed
1 of 4 tasks

Use TopSky on TC/APP Displays #751

luke11brown opened this issue May 26, 2024 · 2 comments · Fixed by #771
Assignees
Labels
enhancement For new or improved features

Comments

@luke11brown
Copy link
Contributor

luke11brown commented May 26, 2024

What is the current situation?

TopSky only used on area profiles

What is the proposed change?

Approach & TC profiles/displays to use TopSky at the minimum to display part time airspace and danger area activations, other features can be omitted. Tag functionalities such as auto text (on heading assign for example) will therefore be retained.

  • Symbols to be disabled (this seems to be the problem, possiblity of using native ES radar track symbols for all)
  • Colours to be changed (see below solution for login callsign based settings)
  • TopSky lines in ASRs require setting up
  • non-TopSky area profiles can have TopSky enabled but retain the tag family

Reference materials (e.g. screenshots)

image
image

Additional context

@luke11brown luke11brown added the enhancement For new or improved features label May 26, 2024
@luke11brown luke11brown self-assigned this May 26, 2024
@luke11brown
Copy link
Contributor Author

luke11brown commented May 28, 2024

Instead of another TopSky instance:

Use TopSkySettingsLocal for the following:
[EGPH_]
(weird colour NOVA)

[EGCC_], [EGPD_] etc.
(normal NOVA)

[_APP]
(NODE)

[LTC_], [MAN_], [STC_]
NODE

Note: ordering of this file is important. It needs to be more general at the start, becoming more login specific. Therefore, it should follow (I think) global, Suffix, Prefix based settings.

OCAS areas to have the following added (infills, but retain outline for all):
ASRDATA:NERC

NERC ASRs to have the following line added:
PLUGIN:TopSky plugin:ShowMapData:NERC

COLORDEF lines in TopSkyMaps.txt and TopSkyAreas.txt to be amended to one of the changeable defintions. e.g. Grey becomes:
Color_Active_Map_Type_1 This can then be changed using the SettingsLocal file
based on login callsign.
Note: Color_Active_Map_Type_1 is currently used for all danger areas.

currently defined in TopSkyMaps.txt

COLORDEF:Grey:80:80:80
COLORDEF:Freetext:65:65:65
COLORDEF:Red:120:0:0
COLORDEF:Line:120:120:120
COLORDEF:Centreline:75:75:75
COLORDEF:OCAS:55:55:57
COLORDEF:CAS:28:28:28
COLORDEF:Fix:140:140:140

Becomes defined in TopSkySettingsLocal.txt

//Danger area (red)
Color_Active_Map_Type_1=120,120,120
//ARTCC High (Grey on NERC)
Color_Active_Map_Type_2=80,80,80
//Freetext
Color_Active_Map_Type_3=65,65,65
//STARs (RMA Lines)
Color_Active_Map_Type_4=120,0,0
//Centrelines
Color_Active_Map_Type_5=75,75,75
//OCAS infill
Color_Active_Map_Type_6=55,55,57
//Sector background infill
Color_Active_Map_Type_7=28,28,28
//Fixes
Color_Active_Map_Type_8=140,140,140

@luke11brown
Copy link
Contributor Author

luke11brown commented Jul 11, 2024

Run 4 versions of TopSky within the pack?

Automation to check parity of certain file such as TopSkyMaps.txt

name: TopSky data match

on: 
  push:
    paths:
      - '/UK/Data/Plugin/TopSky/TopSkyMaps.txt'
      - '/UK/Data/Plugin/TopSky_iTEC/TopSkyMaps.txt'
      - '/UK/Data/Plugin/TopSky_iTEC/TopSkyMaps.txt'

jobs:
  check_files:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout repository
        uses: actions/checkout@v2

      - name: Check if files match
        run: |
          if ! cmp --silent TopSkyMaps.txt file2.txt || ! cmp --silent file1.txt file3.txt; then
            echo "TopSKyMaps.txt files do not match!"
            exit 1
          fi
        shell: bash

TopSky files that should be the same across instances

  • ICAO_Aircraft.json
  • ICAO_Aircraft.txt
  • ICAO_Airlines.txt
  • ICAO_Airports.txt
  • TopSkyAirspace.txt
  • TopSkyAreas.txt
  • TopSkyCallsigns.txt
  • TopSkyCallsignsLocal.txt
  • TopSkyCPDLC.txt
  • TopSkyCPDLChoppieCode.txt
  • TopSkyMaps.txt
  • TopSkyMSAW.txt
  • TopSKyRadars.txt
  • TopSkySSRCodes.txt

@luke11brown luke11brown reopened this Jul 24, 2024
luke11brown added a commit that referenced this issue Aug 5, 2024
* Chnage folder structure to 4 instances of TopSky

* Point NERC profiles at NERC TopSky

* Copy NERC data for start into NOVA and NODE folders

* Add TopSky datafile checking workflow

* add pull request trigger

* Fix typo

* Remove double name line

* Fix missing data discovered by workflow in iTEC TopSkyAreas.txt

* Remove Sam's Hoppie code

* job name change

* Underscores

* checkout@v3

* Add NERC and iTEC colour defintions to Settings.txt

* Fix red/grey colordefs in NERC

* Change TopSkyMaps.txt files to dynamic colordefs

* Remove SSRCodes from check

* NODE color defintions added

* NODE radar symbols

* Fix fix error in NODE Symbols

* NODE tag colours

* CPDLC window overlap

* NOVA Symbols

* Spaces -> :

* Missing symbol type defs

* Make grey OCAS exclusive to NERC displays

* Add TopSky to all TC & APP profiles

* Add Lines to disable HideIfCOPX for AHDG fields

* Add TopSky dummy items to NODE tags

* Grey out unconcerened (NODE)

* Fix duplicate TopSky data lines

* changelog

* cl again

* Chnage NODE TopSky colours

* Revert Gatwick plugins.txt

* Change LTC,MPC,STC Non concerned & notified

* Change TC_APP2 non concerned & notified

* Update EGPH 24 Extended Centreline

* Remove Geo (SCT defined) extended centrelines from NODE/NOVA Displays

* Remove EGBE extended centreline

* NOVA intial colours

* NOVA colour changes

* Danger areas labels recolour NODE/NOVA

* Remove conditional airspace activated by SCT

* Attempt to hide NERC only fixes on itec,NODE,NOVA

* attempt 2

* This now reenables them on all, so reverting

* Disable NERC overlap TopSky fixes and fix labels on non NERC displays

* Add Arvid's SEP click actions

* Ensure PEPZE CTA-2 outline is drawn on all displays

* Ensure PEPZE CTA-2 outline is drawn on all displays

* Disable SCT2 controlled danger areas that are controlled by TopSky

* Attempt to disable extended centreline ticks on TC1&2 displays

* Add comments to NOVA colour schema

* Delete old TopSky folder

* Update to TopSky 2.5b10

* Uodate LogonDetails.py to write to all TopSky instances

* Disable SCT controlled tickless centrelines

* Reenable ticks in NERC displays

* Attempt to diable TopSky_NOVA RPS symbols

* Switch Belfast to TopSky_NODE

* Disable TopSky RPS on NODE

* Yellow -> Pink on NODE

* NODE TopSky colours again

* TopSky 2.5b11

* SettingLocal comments

* Belfast TopSky Settings

* Birmingham TopSky Settings

* Bristol TopSky colours

* Cardiff TopSky colours

* Fix Cardiff TopSky inhibits

* EGNX TopSky colours

* EGPH TopSky colours

* EGTE TopSky colours

* EGPF TopSky colours

* EGNM TopSky colours

* EGGP TopSky Colours

* EGCC TopSky colours

* EGNT TopSky Colours

* Solent TopSky colours

* EGMC TopSky colours

* Utilise AND_ACTIVE for runway dependent RMAs

* Match danger areas label colours

* Revert "Match danger areas label colours"

This reverts commit 7b4a199.

* Try again to match labels to danger areas

* Remove CATEGORYDEF lines as it is no longer used.

* Revert "Remove CATEGORYDEF lines as it is no longer used."

This reverts commit 1765ae2.

* another attempt

* Add label text lines to local settings

* dcenter values for NOVA

* Add ASRDATA:Centrelines

* Show centrelines on NERC

* Disable TopSky centrelines on NOVA that use ES extended centrelines

* EGPH centreline for only active ARR RWY

* Reenable TopSky centrelines on all except EDI

* Remove default extended centrelines for GD,FF,TE,NM

* Remove NERC outline overlap drawings on non NERC displays

* merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For new or improved features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants